Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-axios] properly handle type imports and avoid duplicate function parameters in generated client #12195

Closed
wants to merge 2 commits into from

Conversation

Stevelriemenbill
Copy link

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@amakhrov
@davidgamero
@mkusaka

@Stevelriemenbill
Copy link
Author

#12193

@pcvonz
Copy link

pcvonz commented Jan 6, 2023

I just ran into this issue. Can someone try to get this merged?

@toj11001
Copy link

toj11001 commented Mar 16, 2023

I'm also having the same issue, would be great if we could get this merged :)
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

@kenisteward
Copy link
Contributor

Just wanna double check why that last node is failing for the PR and I can try to give this a once over before my flight

@macjohnny
Copy link
Member

closing in favor of #18625

@macjohnny macjohnny closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants