Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5] fix generation of multiple security definitions #13617

Merged
merged 2 commits into from Oct 7, 2022
Merged

[swift5] fix generation of multiple security definitions #13617

merged 2 commits into from Oct 7, 2022

Conversation

Jonas1893
Copy link
Contributor

@Jonas1893 Jonas1893 commented Oct 6, 2022

This PR fixes #13613:

  • Uses the correct mustache variable to check for the need for authentication of an endpoint
  • updated samples to have one endpoint where multiple security schemes are being used

Verification of the fix can be done either manually via provided swagger from bug report or via updated sample spec. Without the fix truetrue is being generated, with the fix just true as expected

Workaround

Updated mustache file from this PR can be provided via the generator cli option -t to have it working for 6.2.0 for now

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. -> @4brunu

Declaration

The program was tested solely for our own use cases, which might differ from yours.

Link to provider information

https://github.com/mercedes-benz

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@4brunu 4brunu merged commit 6f3c0a8 into OpenAPITools:master Oct 7, 2022
@honkmaster
Copy link
Contributor

@4brunu Any ETA for a release?

@4brunu
Copy link
Contributor

4brunu commented Oct 10, 2022

Hi @honkmaster, looking at the readme I found this.
https://github.com/OpenAPITools/openapi-generator#11---compatibility
But if you are in a hurry, I would suggest that you build the project locally and use the jar directly, it's what I do.
https://github.com/OpenAPITools/openapi-generator#14---build-projects

@wing328 wing328 added this to the 6.2.1 milestone Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants