-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csharp] Fix property names #13681
Merged
Merged
[csharp] Fix property names #13681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as discussed, this is a breaking change without fallback so we'll target 7.0.0 release instead. |
5 tasks
@devhl-labs can you please resolve the merge conflicts when you've time? Then we'll get it merged into 7.0.0 as it'a a breaking change without fallback. |
Yes, will fix it soon. |
please resolve the merge conflicts then I'll merge this one first. |
wing328
reviewed
May 28, 2023
...penapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java
Show resolved
Hide resolved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change fixes multiple issues.
-Underscored variables are usually for private fields. Its pretty unusual to use it for anything else
-Previously, only CodegenModel#vars was getting the property names corrected. That should be fine, but due to the various property collections containing different instances of CodegenProperties (another issue imho) it is not.
-Ensures that the property and the related model constructor parameter have the same name (see the image below). When they are different it can cause deserialization to fail.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)