Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fixes endpoint overload type hint + required property not in properties #13790

Merged
merged 4 commits into from Oct 22, 2022

Conversation

spacether
Copy link
Contributor

@spacether spacether commented Oct 22, 2022

  • Fixes endpoint overload type hint when there is no request body
  • Fixes schema required property not in properties use case

Note:
This makes the python client here have the same fixes as the 1.02 release from here:
https://github.com/openapi-json-schema-tools/openapi-json-schema-generator/releases/tag/1.0.2

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@spacether spacether changed the title [python] fixes [python] Fixes endpoint overload type hint + required property not in properties Oct 22, 2022
@spacether spacether added this to the 6.2.1 milestone Oct 22, 2022
@spacether spacether merged commit ac3bb68 into OpenAPITools:master Oct 22, 2022
@spacether spacether deleted the feat_python_fixes branch October 22, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][PYTHON] adding a requirement on a sibling field in an allOf throws AttributeError on import
1 participant