Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Tests] Fix flaky test in SharedTypeScriptTest.java #13956

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

yannizhou05
Copy link
Contributor

The test below in SharedTypeScriptTest.java was found flaky because of the ordering of result Array. The orders of elements in the Array are not the same as every time the test being called. In this case, the result array was sorted to ensure the orders do not cause the flakiness. This code change is trying to fix the flaky tests mentioned above, because they sometimes fail (as the picture showed) and sometimes pass. The failure could be reproduced by the commands above by using the tool of NonDex. The code change is to make sure the tests will always pass in this case.

  • org.openapitools.codegen.typescript.SharedTypeScriptTest.toModelImportMapTest

The test failures could be reproduced by

  1. mvn install -pl modules/openapi-generator -am -DskipTests
  2. run tests with NonDex
    mvn -pl modules/openapi-generator edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.openapitools.codegen.typescript.SharedTypeScriptTest#toModelImportMapTest

1

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@yannizhou05 yannizhou05 changed the title Fix flaky test in SharedTypeScriptTest.java [Java][Tests] Fix flaky test in SharedTypeScriptTest.java Nov 17, 2022
@wing328 wing328 added this to the 6.3.0 milestone Dec 6, 2022
@wing328
Copy link
Member

wing328 commented Dec 6, 2022

LGTM. Thanks for the PR.

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

@wing328 wing328 merged commit d06ab43 into OpenAPITools:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants