[typescript] Add importFileExtension
option to support ECMAScript module resolution
#14371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js ECMAScript module resolution requires file extensions for relative imports. Typescript also conforms to this requirement when using the new
nodenext
module resolution setting.File extension support was already added to the Typescript(experimental) generator for Deno in #6732. The current PR generalizes the
extensionForDeno
parameter intoimportFileExtension
and makes it user configurable, so users can set it to.js
for a pure ESM package or.mjs
for a dual package.The current PR only adds the option to
TypeScriptClientCodegen
, which seems to be the new generator if I understand it right, but if the PR is accepted, I'd like to try adding it toAbstractTypeScriptClientCodegen
as well in a separate PR, to supporttypescript-fetch
and friends.fixes #14333
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka