Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Go] consider allOf schemas for rendering string default vaules #14684

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

jlsherrill
Copy link
Contributor

@jlsherrill jlsherrill commented Feb 13, 2023

Fixes #14665 See this issue for reproducer information. This fix does resolve the mentioned issue, but I'm not certain if it is the correct approach.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jlsherrill
Copy link
Contributor Author

FYI technical committee: @antihax @grokify @kemokemo @jirikuncar @ph4r5h4d

@dkliban
Copy link
Contributor

dkliban commented Feb 17, 2023

@wing328 Please take a look at this PR.

@wing328
Copy link
Member

wing328 commented Feb 18, 2023

@jlsherrill thanks for the PR. We can accept this PR and later I will work on another PR to address similar issue/use case in default codegen so that all generators do not need to apply similar change.

@wing328 wing328 merged commit e9f55c0 into OpenAPITools:master Feb 18, 2023
@wing328 wing328 added this to the 6.4.0 milestone Feb 18, 2023
wing328 added a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Go] Default string values of enums are not double quoted
3 participants