Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using @objcMembers to expose all props and funcs to ObjC #15188

Merged
merged 1 commit into from Apr 14, 2023

Conversation

tsanidas
Copy link
Contributor

When using the objcCompatible option for swift5, this will add @objcMembers instead of @objc at the generated class level for Models and APIs so that all properties and functions will be visible by Objective-C. I had suggested this in issue 13175 as an enhancement.
I've re-generated the samples, which now reflect this change, and there are no changes to docs.

Attn: @jgavris @ehyche @Edubits @jaz-ah @4brunu

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Apr 11, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@tsanidas
Copy link
Contributor Author

tsanidas commented Apr 11, 2023

@wing328 Ok, I hope that fixed it. Incorrectly juggled work email with GitHub email.

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for creating this PR 👍

@4brunu 4brunu merged commit 6a67551 into OpenAPITools:master Apr 14, 2023
11 checks passed
@tsanidas tsanidas deleted the fix_issue13175 branch April 14, 2023 15:30
@wing328 wing328 added this to the 6.6.0 milestone May 9, 2023
@wing328 wing328 changed the title Issue 13175 - using @objcMembers to expose all props and funcs to ObjC Using @objcMembers to expose all props and funcs to ObjC May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants