Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xojo client generator #15194

Merged
merged 5 commits into from May 3, 2023
Merged

Add Xojo client generator #15194

merged 5 commits into from May 3, 2023

Conversation

Topheee
Copy link
Contributor

@Topheee Topheee commented Apr 11, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

This PR adds support for client generation in the somewhat exotic programming language Xojo. It is essentially a BASIC dialect. Since I do not suppose anyone wants to be on the technical committee, I added myself for this particular language.

I hope I did not miss anything for this PR. Otherwise, please let me know.

@wing328
Copy link
Member

wing328 commented Apr 13, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@Topheee
Copy link
Contributor Author

Topheee commented Apr 13, 2023

Hi @wing328,
thx for the quick response! You are right, I added the email to my account and I am now correctly referenced in the commit list.
If I am missing anything else please let me know.

@wing328
Copy link
Member

wing328 commented May 3, 2023

@Topheee thanks for the PR, which looks good to start with. I'll file another PR to make some minor improvements.

@wing328 wing328 merged commit 45a3fe0 into OpenAPITools:master May 3, 2023
8 of 11 checks passed
tiffmaelite added a commit to tiffmaelite/openapi-generator that referenced this pull request Jun 5, 2023
wing328 pushed a commit that referenced this pull request Jun 6, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants