Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elm] Fix printing empty notes #15238

Merged
merged 1 commit into from Apr 17, 2023

Conversation

Qluxzz
Copy link
Contributor

@Qluxzz Qluxzz commented Apr 16, 2023

Fix printing empty notes since an empty string is truthy

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @eriktim

@Qluxzz
Copy link
Contributor Author

Qluxzz commented Apr 16, 2023

I know there's an option to change this globally for the entire code generator but I feel like doing this explicitly and keeping the standard compiler behavior of treating empty strings as true might be good.

@wing328
Copy link
Member

wing328 commented Apr 17, 2023

Right. I'm ok with your approach. Let's give it a try.

@wing328 wing328 merged commit 096aabd into OpenAPITools:master Apr 17, 2023
16 checks passed
@wing328 wing328 added this to the 6.6.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants