Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Allow clients to define TLS Server name (SNI) #15283

Merged
merged 1 commit into from
May 5, 2023

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented Apr 21, 2023

This PR allows users to define custom SNI when using the python clients

Fixes #15282

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the [technical committee]

cc @spacether (2019/11) @krjakbrjak (2023/02)

This PR allows users to define custom SNI when using the python clients

Fixes OpenAPITools#15282
@wing328
Copy link
Member

wing328 commented May 5, 2023

tests passed via #15420

@wing328 wing328 merged commit 56495d1 into OpenAPITools:master May 5, 2023
7 checks passed
@wing328 wing328 added this to the 6.6.0 milestone May 9, 2023
multani added a commit to multani/openapi-generator that referenced this pull request Aug 22, 2023
This configures the same as in OpenAPITools#15283 but for the aiohttp backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Python client does not support tls-server-name
2 participants