Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP client] Fix README.md template for php #1540

Merged
merged 2 commits into from Nov 26, 2018

Conversation

okapon
Copy link
Contributor

@okapon okapon commented Nov 25, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @jebentier (2017/07) @dkarlovi (2017/07) @mandrean (2017/08) @jfastnacht (2017/09) @ackintosh (2017/09) @ybelenko (2018/07)

Description of the PR

I fixed README.mustache template for php.

There is a problem with the php client's Installation & Usage section.

Please see composer documentation bellow.
https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository

@wing328
Copy link
Member

wing328 commented Nov 26, 2018

The VCS driver to be used is detected automatically based on the URL. However, should you need to specify one for whatever reason, you can use git-bitbucket, hg-bitbucket, github, gitlab, perforce, fossil, git, svn or hg as the repository type instead of vcs.

Thanks for the PR. I agree vcs is a better choice.

@wing328 wing328 added this to the 3.3.4 milestone Nov 26, 2018
Copy link
Contributor

@ackintosh ackintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. ✨

@wing328 wing328 merged commit ce02538 into OpenAPITools:master Nov 26, 2018
@okapon
Copy link
Contributor Author

okapon commented Nov 26, 2018

Thank you very much ✨

@okapon okapon deleted the fix-php-readme branch November 26, 2018 07:20
@wing328
Copy link
Member

wing328 commented Dec 4, 2018

@okapon thanks for the PR, which has been included in the v3.3.4 release: https://twitter.com/oas_generator/status/1068772409795207168

@okapon
Copy link
Contributor Author

okapon commented Dec 4, 2018

@wing328 Thank you for letting me know 😄

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* Fix README.md template for php

* update php openapi3 samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants