Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp-netore][generichost] Renamed ToModel to AsModel #15662

Merged
merged 2 commits into from
May 28, 2023

Conversation

devhl-labs
Copy link
Contributor

When you cast an object using the as keyword, the object is nullable such as TType?
This change mirrors that convention, and also allows us to have a ToModel which returns TType or throws. That will come in a later PR.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 merged commit 29223e0 into OpenAPITools:master May 28, 2023
37 checks passed
@wing328 wing328 added this to the 7.0.0 milestone May 28, 2023
@wing328
Copy link
Member

wing328 commented May 28, 2023

@devhl-labs thanks for the PR, which has been merged. I've marked it as a breaking change without fallback.

@devhl-labs devhl-labs deleted the as-model branch May 28, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants