Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major Jetbrains HTTP Client upgrade. Move to BETA #15779

Merged

Conversation

jlengrand
Copy link
Contributor

@jlengrand jlengrand commented Jun 7, 2023

Do not merge, this is meant to be WIP and used for CI Getting ready for merge!

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jlengrand jlengrand changed the title [WIP] Ass depth to the Jetbrains HTTP Client [WIP] Ad depth to the Jetbrains HTTP Client Jun 7, 2023
@jlengrand jlengrand changed the title [WIP] Ad depth to the Jetbrains HTTP Client [WIP] Add depth to the Jetbrains HTTP Client Jun 7, 2023
@jlengrand jlengrand changed the title [WIP] Add depth to the Jetbrains HTTP Client Major Jetbrains HTTP Client upgrade. Move to BETA Mar 5, 2024
@jlengrand
Copy link
Contributor Author

@jlengrand @gcatanese @wing328 FYI!

@jlengrand jlengrand marked this pull request as ready for review March 5, 2024 22:15
@jlengrand
Copy link
Contributor Author

Alright all checks have passed, let me know how I can help making this a successful review. All notable changes are in JetbrainsHttpClientClientCodegen and api.mustache

@gcatanese
Copy link
Contributor

@jlengrand @wing328 Looks good!

.gitignore Show resolved Hide resolved
@wing328 wing328 added this to the 7.4.0 milestone Mar 9, 2024
@wing328 wing328 merged commit f1fcceb into OpenAPITools:master Mar 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants