Add support for Angular 16 #15925

VladimirSvoboda · 2023-06-26T09:40:45Z

The dependencies have been updated accordingly.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
In case you are adding a new generator, run the following additional script :
```
./bin/utils/ensure-up-to-date
```
Commit all changed files.
File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

amakhrov

Thanks for your PR!

Looks good overall - just a few questions regarding dependencies versions

amakhrov · 2023-06-26T16:54:22Z

README.md

@@ -73,7 +73,7 @@ OpenAPI Generator allows generation of API client libraries (SDK generation), se

 |                                  | Languages/Frameworks                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                |
 | -------------------------------- |-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| **API clients**                  | **ActionScript**, **Ada**, **Apex**, **Bash**, **C**, **C#** (.net 2.0, 3.5 or later, .NET Standard 1.3 - 2.1, .NET Core 3.1, .NET 5.0. Libraries: RestSharp, GenericHost, HttpClient), **C++** (Arduino, cpp-restsdk, Qt5, Tizen, Unreal Engine 4), **Clojure**, **Crystal**, **Dart**, **Elixir**, **Elm**, **Eiffel**, **Erlang**, **Go**, **Groovy**, **Haskell** (http-client, Servant), **Java** (Apache HttpClient 4.x, Apache HttpClient 5.x, Jersey1.x, Jersey2.x, OkHttp, Retrofit1.x, Retrofit2.x, Feign, RestTemplate, RESTEasy, Vertx, Google API Client Library for Java, Rest-assured, Spring 5 Web Client, MicroProfile Rest Client, Helidon), **Jetbrains HTTP Client**, **Julia**, **k6**, **Kotlin**, **Lua**, **N4JS**, **Nim**, **Node.js/JavaScript** (ES5, ES6, AngularJS with Google Closure Compiler annotations, Flow types, Apollo GraphQL DataStore), **Objective-C**, **OCaml**, **Perl**, **PHP**, **PowerShell**, **Python**, **R**, **Ruby**, **Rust** (hyper, reqwest, rust-server), **Scala** (akka, http4s, scalaz, sttp, swagger-async-httpclient), **Swift** (2.x, 3.x, 4.x, 5.x), **Typescript** (AngularJS, Angular (2.x - 15.x), Aurelia, Axios, Fetch, Inversify, jQuery, Nestjs, Node, redux-query, Rxjs), **XoJo** |
+| **API clients**                  | **ActionScript**, **Ada**, **Apex**, **Bash**, **C**, **C#** (.net 2.0, 3.5 or later, .NET Standard 1.3 - 2.1, .NET Core 3.1, .NET 5.0. Libraries: RestSharp, GenericHost, HttpClient), **C++** (Arduino, cpp-restsdk, Qt5, Tizen, Unreal Engine 4), **Clojure**, **Crystal**, **Dart**, **Elixir**, **Elm**, **Eiffel**, **Erlang**, **Go**, **Groovy**, **Haskell** (http-client, Servant), **Java** (Apache HttpClient 4.x, Apache HttpClient 5.x, Jersey1.x, Jersey2.x, OkHttp, Retrofit1.x, Retrofit2.x, Feign, RestTemplate, RESTEasy, Vertx, Google API Client Library for Java, Rest-assured, Spring 5 Web Client, MicroProfile Rest Client, Helidon), **Jetbrains HTTP Client**, **Julia**, **k6**, **Kotlin**, **Lua**, **N4JS**, **Nim**, **Node.js/JavaScript** (ES5, ES6, AngularJS with Google Closure Compiler annotations, Flow types, Apollo GraphQL DataStore), **Objective-C**, **OCaml**, **Perl**, **PHP**, **PowerShell**, **Python**, **R**, **Ruby**, **Rust** (hyper, reqwest, rust-server), **Scala** (akka, http4s, scalaz, sttp, swagger-async-httpclient), **Swift** (2.x, 3.x, 4.x, 5.x), **Typescript** (AngularJS, Angular (2.x - 16.x), Aurelia, Axios, Fetch, Inversify, jQuery, Nestjs, Node, redux-query, Rxjs), **XoJo** |


not really a blocker - but looks like the min version the angular generator supports is 9.x, not 2.x

amakhrov · 2023-06-26T17:06:04Z

...nerator/src/main/java/org/openapitools/codegen/languages/TypeScriptAngularClientCodegen.java

@@ -341,7 +352,9 @@ private void addNpmPackageGeneration(SemVer ngVersion) {
        }

        // set zone.js version
-        if (ngVersion.atLeast("15.0.0")) {
+        if (ngVersion.atLeast("16.0.0")) {
+            additionalProperties.put("zonejsVersion", ">=0.11.5,<=0.14");


not sure how exactly it's used in the templates. but the min required version is 0.13.x, as per the migration guide:
https://update.angular.io/?l=3&v=15.0-16.0

Angular v16 supports Zone.js version 0.13.x or later.

Indeed, I've fixed the dependencies specifications.

amakhrov · 2023-06-26T17:14:50Z

samples/client/petstore/typescript-angular-v16-provided-in-root/builds/default/README.md

+
+@NgModule({
+    imports: [
+        ApiModule,


passing note, not a blocker

no idea why this module is needed at all. the services are provided in root.
without specifying a custom config it's meaningless. if we need to provide a custom config, it can be done directly with an injection token.
using a module for this purpose doesn't match modern practices in Angular itself

Removing the module might be breaking for existing projects; using the module itself is anyways optional I think. A modern project doesn't need to import the module at all.

Maybe something to consider for a next major version

Even if they are currently not run.

amakhrov · 2023-06-30T19:01:08Z

@macjohnny looks like it's ready for merging

twatzl · 2023-07-05T08:08:30Z

Any estimates when a version containing this change will be released?

wing328 · 2023-07-05T08:12:26Z

I'll try to release v7.0.0-beta this week

amakhrov reviewed Jun 26, 2023

View reviewed changes

amakhrov mentioned this pull request Jun 27, 2023

support angular 16 in typescript-angular generator #15934

Closed

VladimirSvoboda added 5 commits June 30, 2023 12:32

Add support for Angular 16

fd52bf6

Fix dependencies specifications

892ba95

Fix minimum angular supported version in readme

5ec8ddd

Update integration tests

8d7fb53

Even if they are currently not run.

Update sample due to rebase

c7b54c8

VladimirSvoboda force-pushed the Angular16 branch from 64843a3 to c7b54c8 Compare June 30, 2023 10:38

amakhrov approved these changes Jun 30, 2023

View reviewed changes

macjohnny merged commit 71528f6 into OpenAPITools:master Jul 1, 2023
17 checks passed

wing328 added Client: TypeScript Enhancement: Compatibility labels Jul 5, 2023

wing328 added this to the 7.0.0 milestone Jul 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Angular 16 #15925

Add support for Angular 16 #15925

VladimirSvoboda commented Jun 26, 2023

amakhrov left a comment

amakhrov Jun 26, 2023

VladimirSvoboda Jun 30, 2023

amakhrov Jun 26, 2023

VladimirSvoboda Jun 30, 2023

amakhrov Jun 26, 2023

akehir Jun 28, 2023

amakhrov Jun 28, 2023

amakhrov commented Jun 30, 2023

twatzl commented Jul 5, 2023

wing328 commented Jul 5, 2023

Add support for Angular 16 #15925

Add support for Angular 16 #15925

Conversation

VladimirSvoboda commented Jun 26, 2023

PR checklist

amakhrov left a comment

Choose a reason for hiding this comment

amakhrov Jun 26, 2023

Choose a reason for hiding this comment

VladimirSvoboda Jun 30, 2023

Choose a reason for hiding this comment

amakhrov Jun 26, 2023

Choose a reason for hiding this comment

VladimirSvoboda Jun 30, 2023

Choose a reason for hiding this comment

amakhrov Jun 26, 2023

Choose a reason for hiding this comment

akehir Jun 28, 2023

Choose a reason for hiding this comment

amakhrov Jun 28, 2023

Choose a reason for hiding this comment

amakhrov commented Jun 30, 2023

twatzl commented Jul 5, 2023

wing328 commented Jul 5, 2023