Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP - Permit to customize more composer.json parts #16012

Merged
merged 1 commit into from Jul 12, 2023

Conversation

hugofintecture
Copy link
Contributor

@hugofintecture hugofintecture commented Jul 5, 2023

This is my first PR. It's a WIP PR I think but it mainly to get some insights on it.

Fix #14645

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@@ -15,12 +15,12 @@
"rest",
"api"
],
"homepage": "https://openapi-generator.tech",
"license": "unlicense",
"homepage": "{{artifactUrl}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use {{{ ... }}} instead of {{ ... }}, which outputs HTML escaped value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will take care of it after merging this PR into master

@wing328 wing328 changed the title Fix #14645 - PHP - Permit to customize more composer.json parts PHP - Permit to customize more composer.json parts Jul 12, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jul 12, 2023
@wing328 wing328 merged commit 9aa6e25 into OpenAPITools:master Jul 12, 2023
1 of 5 checks passed
@hugofintecture hugofintecture deleted the fix-14645 branch July 12, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [PHP] Generate correct composer.json metadata
2 participants