Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript-nestjs] allow configuration with forRootAsync #16112

Merged

Conversation

BerniWittmann
Copy link
Contributor

@BerniWittmann BerniWittmann commented Jul 17, 2023

Allow the configuration of the nestjs module with different providers via forRootAsync. This will RESOLVE #15269.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@BerniWittmann
Copy link
Contributor Author

BerniWittmann commented Jul 17, 2023

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka
I'd be glad about your review on my PR to add more configuration options to typescript-nestjs generator. This will resolve #15269

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@macjohnny macjohnny merged commit b7346d0 into OpenAPITools:master Jul 22, 2023
16 checks passed
@wing328 wing328 added this to the 7.0.0 milestone Aug 16, 2023
@wing328 wing328 changed the title [typescript-nestjs] allow configuration with forRootAsync (#15269) [typescript-nestjs] allow configuration with forRootAsync Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ][typescript-nestjs] Option for configuring via another provider like forRootAsync
3 participants