Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 32bit in postdata #16238

Merged
merged 1 commit into from Aug 3, 2023
Merged

Conversation

hai22yu23
Copy link
Contributor

libcurl API curl_easy_setopt requires the third parameter has to be passed with correct type depending on specific option.
For CURLOPT_POSTFIELDSIZE_LARGE option, it has to be type curl_off_t which is expected to be 64bit whether on 32bit or 64bit platform.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@hai22yu23
Copy link
Contributor Author

link in kubeClient-c
kubernetes-client/c#199

@wing328
Copy link
Member

wing328 commented Aug 2, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Aug 2, 2023

please follow step 3 to update the samples so that the CI can verify the change.

@hai22yu23
Copy link
Contributor Author

please follow step 3 to update the samples so that the CI can verify the change.
Thanks for your instruction.
where can I find the step 3, is there a link for step3?

@wing328
Copy link
Member

wing328 commented Aug 2, 2023

in the PR checklist: #16238 (comment)

cc @zhemant (2018/11) @ityuhui (2019/12) @michelealbano (2020/03)

Copy link
Contributor

@ityuhui ityuhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hai22yu23
Copy link
Contributor Author

please follow step 3 to update the samples so that the CI can verify the change.

samples has been updated

@hai22yu23
Copy link
Contributor Author

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

I have updated the commit message, but I am not sure whether it works. Could you please help to check? if it doesn't work, please help to add account info in to this commit message. account info ("hai22yu23 haiyu.xu@windriver.com").
Thanks a lot!

@wing328 wing328 added this to the 7.0.0 milestone Aug 3, 2023
@wing328 wing328 merged commit cb56e50 into OpenAPITools:master Aug 3, 2023
16 of 17 checks passed
@wing328
Copy link
Member

wing328 commented Aug 3, 2023

@hai22yu23 looks good. PR merged. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants