Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][aspnetcore] Fix ASP.NET Core server DateTimeOffset type mapping #16653

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

seniorquico
Copy link
Contributor

Following the changes in #15967, this fixes the DateTimeOffset option in the ASP.NET Core server stub template. Notably, the setTypeMapping method overload no longer does anything that the base method doesn't already set up. But the existing overload overrides and breaks the DateTimeOffset mapping, forcing it always to DateTime. I compiled locally and ran the generator, confirming that this indeed produces a DateTimeOffset in a generated server stub.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha

@wing328 wing328 added this to the 7.1.0 milestone Sep 23, 2023
@wing328 wing328 merged commit 7d60a46 into OpenAPITools:master Sep 23, 2023
16 checks passed
@seniorquico seniorquico deleted the patch-2 branch September 23, 2023 13:27
AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants