Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-next-gen] fix handling with enums in object serializer #16741

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

reinfi
Copy link
Contributor

@reinfi reinfi commented Oct 5, 2023

I am unsure if the whole check could be removed because in the setter method of the model there is a phpdoc typehint which states that only an enum is allowed. But as long as there are no native type hints it could not be ensured that the value is always an enum.

$data in this case should never be overwritten because it contains the OpenApi information.

In my opinion serialization of the value should always be a scalar value because otherwise receiving clients must understand PHP enums serialization.

Offtopic: there are some more issues with enums, i.e. in query parameters. But I will fix them with separate pull requests so they are clean and simple.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@reinfi
Copy link
Contributor Author

reinfi commented Oct 5, 2023

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

Still feels awkward to mention so many people :-D

@wing328 wing328 added this to the 7.1.0 milestone Oct 6, 2023
@wing328 wing328 merged commit f568001 into OpenAPITools:master Oct 7, 2023
16 checks passed
@wing328
Copy link
Member

wing328 commented Oct 7, 2023

@reinfi thanks for the PR, which has been merged into the master

Can you please PM me via Slack when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328
Copy link
Member

wing328 commented Oct 10, 2023

FYI. I've created a Slack channel (https://app.slack.com/client/TLQFRCNJZ/C0600D9TMK9) to facilitate discussions related to the PHP generators

AlanCitrix pushed a commit to AlanCitrix/openapi-generator that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants