Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix postponed model imports #16882

Merged

Conversation

OliverTetzTT
Copy link
Contributor

The postponed model imports are wrong when the mapping name is not equal to the model name.

See Issue for example schema and further description.

I changed the method used in the python pydantic generators to use the model name for the postponed imports instead of the mapping name of the discriminator mapping.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Contributor

@fa0311 fa0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good To Me

@OliverTetzTT
Copy link
Contributor Author

Is there any reason, why this is not merged? Is something missing? :)

@wing328
Copy link
Member

wing328 commented Nov 1, 2023

@OliverTetzTT sorry for the delay as there are too many PRs.

Will merge once all tests pass

@OliverTetzTT
Copy link
Contributor Author

@wing328 no problem. I was just wondering. I might have some other contributions coming and wanted to make sure I made things right 😄

@wing328 wing328 merged commit 4402635 into OpenAPITools:master Nov 1, 2023
16 checks passed
@wing328
Copy link
Member

wing328 commented Nov 1, 2023

Just merged. Look forward to your PRs. Have a good day.

@wing328 wing328 added this to the 7.1.0 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants