Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust-server): remove redundant clone #16906

Merged
merged 1 commit into from Oct 27, 2023

Conversation

nathanielc
Copy link
Contributor

@nathanielc nathanielc commented Oct 25, 2023

The generated example code would clone the context. However as context is a generic type and is not declared to implement Clone, a clone of a reference is just a copy of the reference and therefore unnecessary. This change removes the redundant call and therefore avoids the cargo clippy warning.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jacob-pro

The generated example code would clone the context. However as context
is a generic type and is not declared to implement Clone, a clone of a
reference is just a copy of the reference and therefore unnecessary.
This change removes the redundant call and therefore avoids the `cargo
clippy` warning.
@wing328
Copy link
Member

wing328 commented Oct 26, 2023

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10)

@wing328 wing328 added this to the 7.1.0 milestone Oct 26, 2023
@wing328 wing328 merged commit fbd0255 into OpenAPITools:master Oct 27, 2023
19 checks passed
@wing328
Copy link
Member

wing328 commented Oct 27, 2023

thanks for the PR, which has been merged.

@nathanielc nathanielc deleted the fix/rust-server-warnings branch October 30, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants