Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N4JS] Fix issue with broken module names in case of same names #16937

Merged

Conversation

mmews-n4
Copy link
Contributor

Fixes situation where two modules have the same name and a '_1' is appended to one of both. However, before the fix the postfix '_1' is sometimes transformed to '1' only, due to a call to StringUtils#camelize(String). The fix in this PR mitigates the situation by always calling camelize(String).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.1.0 milestone Oct 30, 2023
@wing328 wing328 merged commit 08d5183 into OpenAPITools:master Oct 30, 2023
15 of 16 checks passed
@mmews-n4
Copy link
Contributor Author

@wing328 Thanks a lot for your super quick response!

@mmews-n4 mmews-n4 deleted the n4js-fix-duplicate-module-names branch October 30, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants