Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] add circular reference import #16940

Merged

Conversation

fa0311
Copy link
Contributor

@fa0311 fa0311 commented Oct 30, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Pydantic v2 has made significant changes to the specifications regarding the reconstruction of models required for circular references.
This requires the construction of a very complex referencing algorithm to resolve.
I hope to have those issues resolved by the 7.1.0 release of openapi-generator. Because importing circular references is needed by many people.
I propose these temporary fixes because I do not want to spend time building a complex referencing algorithm.

I would prefer not to use raise_errors, but it is very useful as a temporary implementation.

@fa0311 @multani

Signed-off-by: ふぁ <yuki@yuki0311.com>
Signed-off-by: ふぁ <yuki@yuki0311.com>
@fa0311
Copy link
Contributor Author

fa0311 commented Oct 30, 2023

Maybe conflicts with #16809

Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix!

@multani
Copy link
Contributor

multani commented Nov 2, 2023

@wing328 I think we can merge this one 👍

@wing328 wing328 merged commit 1092593 into OpenAPITools:master Nov 2, 2023
26 checks passed
@wing328 wing328 added this to the 7.1.0 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants