Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parameters_to_url_query returns booleans with upper letter #16947

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

mhaley-tignis
Copy link
Contributor

@mhaley-tignis mhaley-tignis commented Oct 31, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mhaley-tignis
Copy link
Contributor Author

Fix for #16941

@mhaley-tignis
Copy link
Contributor Author

if isinstance(v, bool):
v = str(v).lower()
if isinstance(v, (int, float)):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In python boolean is a subclass of int so isinstance(True, (int, float)) == True. We need to check if the type is boolean before checking if the type is a number to get the behaviour we desire.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In python boolean is a subclass of int so isinstance(True, (int, float)) == True. We need to check if the type is boolean before checking if the type is a number to get the behaviour we desire.

TIL it's still the case in Python 3, I thought this was only the case in 2.x 👍

@wing328
Copy link
Member

wing328 commented Oct 31, 2023

@mhaley-tignis thanks for the PR. Can you please take a look at the test failure when you've time?

@mhaley-tignis
Copy link
Contributor Author

@mhaley-tignis thanks for the PR. Can you please take a look at the test failure when you've time?

whoops, yes, missed that &, see f6da174

@mhaley-tignis
Copy link
Contributor Author

ok @wing328, should be good now. I rushed this and didn't really look at the exception the first time. Sorry about that!

@wing328
Copy link
Member

wing328 commented Oct 31, 2023

no need to sorry and thanks for your PR to improve the Python client generator.

Copy link
Contributor

@multani multani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix @mhaley-tignis !

@wing328 wing328 merged commit a4267ee into OpenAPITools:master Nov 1, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants