Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Use int* as int or bool type function parameter #17179

Merged

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Nov 24, 2023

@wing328 @zhemant (2018/11) @michelealbano (2020/03)

As discusseded in kubernetes-client/c#209, this PR uses int* as int or bool type function parameter.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ityuhui
Copy link
Contributor Author

ityuhui commented Dec 4, 2023

Hi @zhemant @michelealbano @wing328
Do you have any comments on this code change ?

@ityuhui
Copy link
Contributor Author

ityuhui commented Dec 9, 2023

@wing328
Since no one objects to this change, can you merge this PR ?
The change will be tested/used by kubernetes C client. So if it breaks some feature, we can find it soon.

@zhemant
Copy link
Contributor

zhemant commented Dec 10, 2023

Hi @ityuhui ,
Sorry for late reply.
I only see changes to api files and not in model files. Do I see this correct? I believe if we are making these changes then they should be for complete client even for model. Because the error that you are facing is true in the case of the model as well.

@ityuhui
Copy link
Contributor Author

ityuhui commented Dec 11, 2023

Yes. This PR only changes api files.

Actually they (api files and model files) are different problems although the solution is same (use int * for int or boolean data types).

This PR only changes "query parameters" in HTTP request header. It does not relate with any model and will resovle the problem of sending request. e.g. kubernetes-client/c#209

For issues related to model files such as kubernetes-client/c#193 (Fetch some models from API server), I will provide another PR next to create/remove int/boolean fields in models.

@wing328
Copy link
Member

wing328 commented Dec 12, 2023

let's try with what you'e so far.

@wing328 wing328 merged commit 2a27fd5 into OpenAPITools:master Dec 12, 2023
17 checks passed
@ityuhui ityuhui deleted the yh-function-parameter-int-star-1120 branch December 13, 2023 01:53
ityuhui added a commit to ityuhui/c that referenced this pull request Dec 14, 2023
…erged:

Use int* as int or bool type function parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants