Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalized mime type support #17285

Merged

Conversation

a-ignatov-parc
Copy link
Contributor

Address #17282

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

@macjohnny
Copy link
Member

@a-ignatov-parc thanks for your contribution!

@a-ignatov-parc
Copy link
Contributor Author

@macjohnny, thanks for the review! Just to manage expectations, I plan to make the suggested changes in the first part of next week 👍

@a-ignatov-parc
Copy link
Contributor Author

@macjohnny, I apologize that addressing the feedback took longer than I initially anticipated. However, the PR is ready for the next round of review 👍

@macjohnny macjohnny merged commit aacea34 into OpenAPITools:master Dec 19, 2023
15 checks passed
@wing328 wing328 added this to the 7.2.0 milestone Dec 22, 2023
@bodograumann
Copy link
Contributor

Hey, I just wanted to say thanks for contributing this, @a-ignatov-parc ! Just when we needed it, all we had to do was update the generator ❤️

@a-ignatov-parc a-ignatov-parc deleted the generalized-mime-type-support branch March 21, 2024 10:00
@a-ignatov-parc
Copy link
Contributor Author

@bodograumann, thank you for the feedback. It's great to know when your contribution has been useful to someone 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants