Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $Response.Content for deserializing response #17342

Merged
merged 1 commit into from Dec 7, 2023

Conversation

Stuv7CB
Copy link
Contributor

@Stuv7CB Stuv7CB commented Dec 7, 2023

Powershell client should use $Response.Content for deserializing response. Converting $Response to string as is replaces non-ascii characters with ?
fix #17340

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Stuv7CB
Copy link
Contributor Author

Stuv7CB commented Dec 7, 2023

@wing328 could you please review this PR

@wing328
Copy link
Member

wing328 commented Dec 7, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Dec 7, 2023

thanks for the PR. I'll test it

@Stuv7CB
Copy link
Contributor Author

Stuv7CB commented Dec 7, 2023

Thank you for pointing out that commit isn't linked to my profile. Force-pushed commit with correct author and committer

@wing328
Copy link
Member

wing328 commented Dec 7, 2023

powershell tests (appveyor) passed via https://ci.appveyor.com/project/WilliamCheng/openapi-generator/builds/48703795

@wing328 wing328 added this to the 7.2.0 milestone Dec 7, 2023
@wing328 wing328 merged commit 3762277 into OpenAPITools:master Dec 7, 2023
16 checks passed
@wing328
Copy link
Member

wing328 commented Dec 7, 2023

thanks for the PR, which has been merged into the master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][POWERSHELL] Powershell client should use $Response.Content for deserializing response
2 participants