[csharp][generichost] Handle obsolete params and methods #17344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I would like
generichostlibrary to support basic method/param deprecation like this: #10084 in the past.I've added conditional
[Obsolete]attribute onI{{Controller}}Apimethods along with(deprecated)in param descriptions, pretty much the same as mentioned PR.We just need anything to show our clients that stuff is deprecated, most of them don't care about
<remarks>...</remarks>but having build warning gets their attention.Let me know if I need to make an issue for this or change/fix something, but it's a fairly simple addition.
Tagging @devhl-labs because as far as I've seen you mostly maintain this library :)