Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Add model name mapping support to ruby client generator #17408

Merged

Conversation

tschoppi
Copy link
Contributor

@tschoppi tschoppi commented Dec 15, 2023

The modelNameMappings were introduced with PRs #16209, #16234 and are now also used in the ruby client generator.

The previously implemented lookup in schemaMappings (PR #12962) still takes precedence.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@tschoppi
Copy link
Contributor Author

@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328
Copy link
Member

wing328 commented Dec 15, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

The modelNameMappings were introduced with PRs OpenAPITools#16209, OpenAPITools#16234 and are
now also used in the ruby client generator.
@tschoppi tschoppi force-pushed the add-model-name-mapping-to-ruby-client branch from 5b4a76d to 39f3be2 Compare December 17, 2023 21:21
@tschoppi
Copy link
Contributor Author

Thanks for the hint, @wing328 . I have changed the author information in the commit accordingly.

@wing328
Copy link
Member

wing328 commented Dec 18, 2023

LGTM. thanks for the enhancement.

@wing328 wing328 merged commit efe2f87 into OpenAPITools:master Dec 18, 2023
5 checks passed
@tschoppi tschoppi deleted the add-model-name-mapping-to-ruby-client branch December 19, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants