Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swift5 binary upload #17422

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

Stormshield-robinc
Copy link
Contributor

#17421

There is two underlying issues that cause the file upload to be broken in swift.
First, we never added the code to read the file when we are in Url mode
Second, we never added the content-type "application/octet-stream", which resulted in the code never using the OctetStreamEncoding

I tested this on my project, and it can now upload files.
The other endpoint of the API have been left untouched and are still working.

While updating the samples, I saw "Content-Type": "application/json" appearing a bit everywhere. I was quite surprised as I did not add this kind of behavior in my project. Since json was the default type, I would not expect this to cause any issues, but I am still quite concerned. Is there any regressions tests ? (sorry, I am very ne to this project)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)

@4brunu
Copy link
Contributor

4brunu commented Dec 21, 2023

Looks good to me, thanks for the contribution.
This was a half baked feature that I never find time to finish it.

@4brunu
Copy link
Contributor

4brunu commented Dec 21, 2023

Uploading files by passing a URL was also a bit strange to me, I was expecting to pass Data, but since this was already done that way before with the Alamofire integration, I used the same integration in URLSession.
Basically I was saving the Data in a temporary file and passing the URL to that file.
But I think that in the future in case the Data integration proves that is solid, we can switch that to be the default one.

@4brunu 4brunu merged commit 0a71402 into OpenAPITools:master Dec 21, 2023
34 checks passed
@4brunu
Copy link
Contributor

4brunu commented Dec 21, 2023

Just to give some additional context mapFileBinaryToData was marked as deprecated because it was a half baked feature.

@wing328 wing328 added this to the 7.2.0 milestone Dec 22, 2023
@Stormshield-robinc
Copy link
Contributor Author

hi,

Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants