Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(php): update type hint in toString method #17838

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Feb 9, 2024

If it's not datetime nor bool, it's string

image

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 12, 2024

thanks for the PRs to improve the PHP generator.

can you please PM me via Slack to discuss and review all your PRs when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@simPod simPod force-pushed the php/object-serializer-string branch from bfdce2e to 774f9a1 Compare February 12, 2024 07:39
@wing328 wing328 merged commit f431540 into OpenAPITools:master Feb 12, 2024
14 checks passed
@wing328 wing328 changed the title fix(php): do not cast to string something that's already string fix(php): update type hint in toString method Feb 12, 2024
@simPod simPod deleted the php/object-serializer-string branch February 12, 2024 08:07
@wing328
Copy link
Member

wing328 commented Feb 12, 2024

as discussed the type hint has been updated to include number

cc
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

kota65535 pushed a commit to kota65535/openapi-generator that referenced this pull request Feb 23, 2024
@wing328 wing328 added this to the 7.4.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants