Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ruby): Detect content-type in form-data file upload using faraday (#17851) #17853

Conversation

dvacca-onfido
Copy link
Contributor

@dvacca-onfido dvacca-onfido commented Feb 13, 2024

Differently than other generators (e.g. Python), Ruby generator using Faraday as HTTP client is not able to provide correct content type when file is uploaded as part of multipart/form-data payload.

Expected: image/jpeg (if JPEG image was uploaded)
Received: application/octet-stream

I'd kindly ask also for guidance in choosing target branch, since the content-type previously provided was clearly wrong, but still this change might possibly break some integrations.

Fixes issue #17851.

@cliffano @zlx @autopp

--


PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 13, 2024

CI tests failed: https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/27900/workflows/148b8cfa-8bca-42f5-8940-e9d6d0cf2520/jobs/88739

can you please take a look when you've time?

@dvacca-onfido
Copy link
Contributor Author

Might it help rebasing my change and generating the examples again?

@@ -1 +1 @@
-7.3.0-SNAPSHOT
\ No newline at end of file
+7.4.0-SNAPSHOT
Perform git status

https://github.com/OpenAPITools/openapi-generator/actions/runs/7887425395/job/21525679113?pr=17853

@wing328
Copy link
Member

wing328 commented Feb 13, 2024

Might it help rebasing my change and generating the examples again?

please merge/pull the latest master into your branch and regenerate the samples again?

PM via slack if you need further assistance

@dvacca-onfido dvacca-onfido force-pushed the ruby-faraday-detect-content-type-in-upload branch from b4653c7 to 3c46490 Compare February 13, 2024 16:23
@wing328
Copy link
Member

wing328 commented Feb 14, 2024

lgtm. thanks for the PR.

@wing328 wing328 merged commit 9deeb60 into OpenAPITools:master Feb 14, 2024
21 checks passed
kota65535 pushed a commit to kota65535/openapi-generator that referenced this pull request Feb 23, 2024
…OpenAPITools#17851) (OpenAPITools#17853)

* fix(ruby): Detect content-type in form-data file upload using faraday (OpenAPITools#17851)

* Update samples

* Add needed dependency libmagic-dev into node 1 setup of Circle Parallel CI

* After merge/pull last master + regeneration of samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants