Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] fix isNil check #17870

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 15, 2024

based on #17840 with update samples

to close #17835

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 changed the title Sagarkhot3 generated model accessor functions have incorrect boolean logic [Go] fix isNil check Feb 15, 2024
@wing328 wing328 marked this pull request as ready for review February 15, 2024 06:17
@wing328 wing328 added this to the 7.4.0 milestone Feb 15, 2024
@wing328 wing328 merged commit 4e39f12 into master Feb 15, 2024
72 checks passed
@wing328 wing328 deleted the sagarkhot3-Generated-model-accessor-functions-have-incorrect-boolean-logic branch February 15, 2024 06:17
@wing328 wing328 mentioned this pull request Feb 15, 2024
5 tasks
kota65535 pushed a commit to kota65535/openapi-generator that referenced this pull request Feb 23, 2024
* OpenAPITools#17835 changed to return !IsNil

* update samples

---------

Co-authored-by: sagar khot <sagarkhot74@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][golang][7.3.0] Generated model accessor functions have incorrect boolean logic for array types
2 participants