Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better array handling in 3.1 spec #18313

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Better array handling in 3.1 spec #18313

merged 2 commits into from
Apr 7, 2024

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Apr 7, 2024

  • Better array handling in 3.1 spec
  • not casting to ArraySchema
  • replace instanceof ArraySchema with isArraySchema
  • move getSchemaItems to model utils class

fyi @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.5.0 milestone Apr 7, 2024
@wing328 wing328 changed the title Better array detection in 3.1 spec Better array handling in 3.1 spec Apr 7, 2024
@wing328 wing328 merged commit 2168851 into master Apr 7, 2024
110 checks passed
@wing328 wing328 deleted the fix-unknown-type branch April 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant