Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional singleRequestParameter #18467

Merged
merged 1 commit into from
May 3, 2024

Conversation

angelaki
Copy link
Contributor

Fixes #18456. Add optional chaining to singleRequestParameter, if all parameters are optional.

@wing328
Copy link
Member

wing328 commented Apr 24, 2024

https://github.com/OpenAPITools/openapi-generator/actions/runs/8798721887/job/24147516590?pr=18467 already fixed in the master

cc TypeScript technical committee for review

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

@wing328
Copy link
Member

wing328 commented Apr 30, 2024

@macjohnny macjohnny merged commit 06b00e6 into OpenAPITools:master May 3, 2024
13 of 14 checks passed
@angelaki
Copy link
Contributor Author

angelaki commented May 6, 2024

Woohoo 🥳 Deployment estimations? Or: when will it hit https://hub.docker.com/r/openapitools/openapi-generator-cli? Doesn't seam to be part of 7.6.0-Snapshot, yet.

@macjohnny
Copy link
Member

Woohoo 🥳 Deployment estimations? Or: when will it hit https://hub.docker.com/r/openapitools/openapi-generator-cli? Doesn't seam to be part of 7.6.0-Snapshot, yet.

i think it should soon be part of the snapshot

@angelaki
Copy link
Contributor Author

angelaki commented May 6, 2024

Woohoo 🥳 Deployment estimations? Or: when will it hit https://hub.docker.com/r/openapitools/openapi-generator-cli? Doesn't seam to be part of 7.6.0-Snapshot, yet.

i think it should soon be part of the snapshot

What kind of soon are you talking about? Minutes? Hours? Days? Thank you! :)

@angelaki
Copy link
Contributor Author

angelaki commented May 6, 2024

So... Shouldn't it be part of the image, yet?

Edit: oh my ... was just my compose file not pulling the latest latest version ... everythings fine, ty!

@wing328 wing328 added this to the 7.6.0 milestone May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [angular-typescript] Support optional paramters for useSingleRequestParameter=true
3 participants