Bugfix/fix for correctly generating additional properties, added types for typescript

[mvarchdev]

Followup for PR #18164 - Optimising fix for additional properties. Added missing types in typescript. Updated tests for Java.

FYI: @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package 
  ./bin/generate-samples.sh ./bin/configs/*.yaml
  ./bin/utils/export_docs_generators.sh
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[macjohnny]

I wonder if its a good idea to use unknown instead of any, since this probably breaks a lot of client code that accesses these values

[mvarchdev]

From the typescript perspective (ECMA standarts etc) it is better to use unknown, as it is exactly describe its state/type, which is unknown and you must check/know the type of it. IMO it make the code more error-free/robust in runtime as you will be forced to check the type.

[mvarchdev]

I can put it back to any but my linter and strict tsconfig settings do not like it, which is sign of not best typing.

[mvarchdev]

Or maybe, make use of config switch supportsES6 that when it would be true, it would use unknown instead of any

[macjohnny]

i would suggest to switch it back to any, in order not to break existing use cases.

[mvarchdev]

Sorry for late reply, had a lot in work... I do not agree with that completely, preserving backwards compatibility si for sure important, but in our codebase, any type will fail in every project as we use strict typing config from official ts configs package. I suggest to add config switch to generator that we will be able to set if any of unknown, as default there would be any so preserving backwards compatibility, what do you think? @macjohnny @andreseloysv

[macjohnny]

applying linting/strict typing rules etc. to generated code is a hard one anyway. you can always just have a custom script to post-process the output and replace any with unknown

a config switch sounds a bit like an overkill here, no?

[mvarchdev]

@macjohnny We use that, because we have strict typing rule in our org :/ and tbh imo, having script to post-process the output and replace any with unknown is overkill as you would change already generated code, instead, with switch, you would just already set what will be generated in the end. In @sunray-eu We would really love to have this switch available. Let me know your final decision if it would be to big change in code with this switch adding, and then, we can finally merge it. Thanks!

[macjohnny]

*shrug* ok lets have the switch. an alternative though would be to generate the code into a separate npm package, and import that package in your project. this way, you dont need to apply your projects build rules.

[mvarchdev]

We have alternative package, of course, but 1. there is also build, 2. when we use it in other package, the return data type is sometimes any, which in lot of cases disable type check