[TS][Axios] Remove redundant right parenthesis #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macjohnny
requested changes
Jan 9, 2019
modules/openapi-generator/src/main/resources/typescript-axios/api.mustache
Outdated
Show resolved
Hide resolved
sruehl
force-pushed
the
bugfix/1848_redundant_right_parenthesis
branch
from
7d7b7bb
to
bccb31b
Compare
|
@macjohnny I left out samples/changes on petstore.yaml intentionally and linked an example in #1848 as I don't wanted to adjust the file for every protocol. Maybe a file with all possibilities would be good for the future so we have a validation of all features in all languages. Another unrelated bug here is that we can define complex types in headers and the won't get stringifyed (But thats a completely different issue). |
|
The CircleCI issue has been fixed in master. |
wing328
changed the title
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
the api.mustache for typescript-axios contains a syntax error when using arrays in header.
Issue: #1848
cc: @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)