Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] uses sanitized model name instead of the name #18644

Merged
merged 6 commits into from
May 12, 2024

Conversation

vvb
Copy link
Contributor

@vvb vvb commented May 12, 2024

Fixes #18632

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5 @wing328

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 12, 2024

thanks for the PR. please add the new folder to https://github.com/OpenAPITools/openapi-generator/blob/master/CI/circle_parallel.sh#L45 so that circleci will test it moving forward.

@wing328
Copy link
Member

wing328 commented May 12, 2024

you will need to add a pom.xml as well in the new folder (by copying it from another go sample folder and modify it a bit, e.g. new artifactId)

@vvb
Copy link
Contributor Author

vvb commented May 12, 2024

you will need to add a pom.xml as well in the new folder (by copying it from another go sample folder and modify it a bit, e.g. new artifactId)

done.

@wing328
Copy link
Member

wing328 commented May 12, 2024

lgtm. thanks for the PR

@wing328 wing328 merged commit 4b56fd2 into OpenAPITools:master May 12, 2024
14 checks passed
@wing328 wing328 added this to the 7.6.0 milestone May 12, 2024
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
* uses sanitized model name instead of the name

* commit sample

* samples updated

* update CI file to test the changes

* adds a pom.xml to the sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Go] Go SDK breaks for parent schema names with special character(._)
2 participants