Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DART2]: fix Map<String, nativeType> fromJson #1936

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

d3v-cl
Copy link
Contributor

@d3v-cl d3v-cl commented Jan 17, 2019

@ircecho @swipesight @jaumard

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Maps with native types could not be deserialized.
_JsonMap is not a Map<String, String>

@wing328
Copy link
Member

wing328 commented Jan 20, 2019

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328
Copy link
Member

wing328 commented Jan 20, 2019

cc @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09)

@d3v-cl
Copy link
Contributor Author

d3v-cl commented Jan 21, 2019

Hi @wing328

I hope this is fixed now.

@ircecho
Copy link
Contributor

ircecho commented Jan 21, 2019

I checked the PR and it looks good to me.

@wing328
Copy link
Member

wing328 commented Jan 25, 2019

@ircecho thanks for reviewing the change.

@d3v-cl thanks for the PR.

@wing328 wing328 merged commit bc6997f into OpenAPITools:master Jan 25, 2019
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants