Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Use double-quote string to enable string interpolation #2068

Merged
merged 1 commit into from Feb 6, 2019

Conversation

autopp
Copy link
Contributor

@autopp autopp commented Feb 6, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
    @cliffano @zlx

Description of the PR

Fix #2067.
By changing from single quote string to double quote string, I made interpolation in the error message work properly.

ref. https://ruby-doc.org/core-2.6.1/doc/syntax/literals_rdoc.html#label-Strings

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me.

@wing328 wing328 merged commit 2876824 into OpenAPITools:master Feb 6, 2019
@wing328 wing328 added this to the 4.0.0 milestone Feb 6, 2019
@autopp autopp deleted the fix-2067 branch February 6, 2019 08:30
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@wing328 wing328 changed the title [Ruby] Use double-quote string to enable string interpolation (#2067) [Ruby] Use double-quote string to enable string interpolation Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants