[typescript-angular] Update default Angular version from 4.3 to 7.0 #2117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
macjohnny
requested changes
Feb 11, 2019
| @@ -93,7 +93,7 @@ public TypeScriptAngularClientCodegen() { | |||
| this.cliOptions.add(new CliOption(PROVIDED_IN_ROOT, | |||
| "Use this property to provide Injectables in root (it is only valid in angular version greater or equal to 6.0.0).", | |||
| SchemaTypeUtil.BOOLEAN_TYPE).defaultValue(Boolean.FALSE.toString())); | |||
| this.cliOptions.add(new CliOption(NG_VERSION, "The version of Angular. Default is '4.3'")); | |||
| this.cliOptions.add(new CliOption(NG_VERSION, "The version of Angular. Default is '6.0.0'")); | |||
There was a problem hiding this comment.
I suggest to use 7.0.0, the most recent stable
| @@ -138,7 +138,7 @@ public void processOpts() { | |||
| if (additionalProperties.containsKey(NG_VERSION)) { | |||
| ngVersion = new SemVer(additionalProperties.get(NG_VERSION).toString()); | |||
| } else { | |||
| ngVersion = new SemVer("4.3.0"); | |||
| ngVersion = new SemVer("6.0.0"); | |||
karismann
changed the title
karismann
deleted the
ts-angular-Update-default-Angular-version-6.0-NPM-Client
branch
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…penAPITools#2117) * [typescript-angular] Update default Angular version from 4.3 to 6.0 (NPM Client) * [typescript-angular] Update default Angular version from 4.3 to 7.0 (NPM Client)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.sh,./bin/security/{LANG}-petstore.shand./bin/openapi3/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10)
Description of the PR
update the default Angular version from 4.3 to 6.0 for generate client with npm libraries
issue #2116
useful link : https://angular.io/guide/releases#support-policy-and-schedule