Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-pistache-server] Fix wrong include path in api-header template #3062

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

mpreu
Copy link
Contributor

@mpreu mpreu commented Jun 2, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Fixes: #3061

Change local json.hpp include path in api-header template to correct value. Samples were updated.

@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03)

Change local json.hpp include path to correct value.

Update samples.
@mpreu mpreu changed the title Fix wrong include path in api-header template [cpp-pistache-server] Fix wrong include path in api-header template Jun 2, 2019
@wing328 wing328 merged commit 1eca97f into OpenAPITools:master Jun 3, 2019
@wing328 wing328 added this to the 4.0.2 milestone Jun 3, 2019
@mpreu mpreu deleted the cpp-pistache-wrong-json-include branch June 3, 2019 08:53
@wing328
Copy link
Member

wing328 commented Jun 20, 2019

Thanks again for the PR, which has been included in the v4.0.2 release: https://twitter.com/oas_generator/status/1141610197766426626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [cpp-pistache-server] Wrong json include path in api-header
4 participants