Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency with jsr250-api #3279

Merged
merged 1 commit into from Jul 5, 2019
Merged

Update dependency with jsr250-api #3279

merged 1 commit into from Jul 5, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Jul 4, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Added jsr250-api to the dependency in Java (okhttp-gson) client.
Updated Travis config to test Java 8 - 12

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04)

@wing328
Copy link
Member Author

wing328 commented Jul 4, 2019

Tested with OpenJDK 8 to 12: https://travis-ci.org/wing328/test-java-okhttp/builds/554224580

(OpenJDK9 issue is caused by Travis. Nothing we can do)

@wing328
Copy link
Member Author

wing328 commented Jul 5, 2019

Similar PR: #3188

@wing328 wing328 merged commit e980929 into master Jul 5, 2019
@wing328 wing328 deleted the java_12 branch July 5, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant