Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Rename template dir #332

Merged
merged 6 commits into from
Jun 17, 2018
Merged

[C++] Rename template dir #332

merged 6 commits into from
Jun 17, 2018

Conversation

ackintosh
Copy link
Contributor

@ackintosh ackintosh commented Jun 17, 2018 •
edited

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Related issue: #138 (comment)

This PR renames template dir to the lower-chain-case of generator name.

e.g. CppRestbedServerCodegen.java: restbed -> cpp-restbed-server

@ackintosh
Copy link
Contributor Author

cc: @ravinikam @stkrwork @fvarose @etherealjoy @MartinDelille

@wing328 wing328 added this to the 3.0.2 milestone Jun 17, 2018
etherealjoy
etherealjoy requested changes Jun 17, 2018
View reviewed changes
Copy link
Contributor

@etherealjoy etherealjoy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All client scripts need to be updated.

ags="generate -t modules/openapi-generator/src/main/resources/qt5cpp --> example

@ackintosh
Copy link
Contributor Author

@etherealjoy Thanks for the comment! Updated the scripts.

@ackintosh
Copy link
Contributor Author

Thank you guys for reviewing this PR.

@ackintosh ackintosh merged commit 75171b4 into OpenAPITools:master Jun 17, 2018
@ackintosh ackintosh deleted the rename-template-dir-cpp branch June 17, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinDelille MartinDelille MartinDelille approved these changes

@etherealjoy etherealjoy etherealjoy approved these changes

Assignees
No one assigned
Labels
Client: C++ Enhancement: Code format Server: C++
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ackintosh @MartinDelille @etherealjoy @wing328