[typescript-node] Promise-based Authentication interface #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) |
|
👋 @wing328 |
macjohnny
reviewed
Jul 22, 2019
modules/openapi-generator/src/main/resources/typescript-node/api-single.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-node/api-single.mustache
Show resolved
Hide resolved
silasbw
commented
Jul 22, 2019
modules/openapi-generator/src/main/resources/typescript-node/api-single.mustache
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/typescript-node/api-single.mustache
Show resolved
Hide resolved
|
Thanks @macjohnny ! Will this go out with the next v4.X.X minor release (v4.1.0, I think)? |
|
Yes, this should be part of 4.1.0 |
Cliabhach
added a commit
to Cliabhach/connect-typescript-node-sdk
that referenced
this pull request
Jul 26, 2019
The main change here is that APIs' authorization is now handled asynchronously. See OpenAPITools/openapi-generator#3408 for details.
|
@silasbw thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Example implementation for #3407.
fixes #3407