[Python] Fix #5126 operations with req enums of length one #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint_enums_length_one
spacether
changed the title
spacether
changed the title
spacether
commented
Jan 28, 2020
| {{/defaultValue}} | ||
| {{/requiredParams}} | ||
| **kwargs | ||
| ): |
There was a problem hiding this comment.
This multiline style comes from the python black code formatter and is valid per pep8
Spreading params out to one per line lets us delete the # noqa: E501 here
|
The CircleCI error is from this unrelated issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the python-experimental generator when we passed in required params/properties with enums of length one, the model
__init__and the Endpoint callable function loaded the constant enum value into the parameter with a named argument with a default value.However a past PR accidentally broke this feature for the Endpoint callable function.
The model init method still sets the default value correctly for required enums of length one, and already has a test here.
This PR:
Related Issues
If merged in, this will close #5126
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.Python Technical Committee:
@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @slash-arun (2019/11) @spacether (2019/11)