Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-angular: Angular 10 support #7037

Merged
merged 4 commits into from Jul 24, 2020
Merged

Conversation

patst
Copy link
Contributor

@patst patst commented Jul 23, 2020

Fixes #7036

  • Change default Angular Version to 10
  • Update libraries for Angular 10
  • Samples for Angular 10
  • Samples for angular 9 for backwards compatibility

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny added this to the 5.0.0 milestone Jul 24, 2020
@macjohnny macjohnny changed the title Angular 10 support typescript-angular: Angular 10 support Jul 24, 2020
@patst
Copy link
Contributor Author

patst commented Jul 24, 2020

@macjohnny thanks for taking a look at it.
Can you give me a hint how to fix the broken circle ci build?

I ran

 ./bin/generate-samples.sh ./bin/configs/typescript-angular-v9-* 
 ./bin/generate-samples.sh ./bin/configs/typescript-angular-v10-* 

locally and committed the changes but this does not seem to help

@macjohnny
Copy link
Member

Maybe the scripts need to be run on a unix system

@lwensveen
Copy link

Maybe the scripts need to be run on a unix system

I presume he ran it in Git bash, which shouldn't differ from unix?

@patst
Copy link
Contributor Author

patst commented Jul 24, 2020

Maybe the scripts need to be run on a unix system

I presume he ran it in Git bash, which shouldn't differ from unix?

I ran it on my Mac and in a Ubuntu docker container as well. Both resulted in no changes

@macjohnny
Copy link
Member

Looking at e.g. https://github.com/patst/openapi-generator/blob/b860af74ce31c00f5fb35283b2526efc4100423d/samples/client/petstore/typescript-angular-v7-not-provided-in-root/builds/default/.openapi-generator/FILES the /./ seems to be present, too. I don‘t know why this happens, but you could also just edit the files manually and commit them to have the CI pass

@macjohnny
Copy link
Member

@patst thanks for your contribution

@macjohnny macjohnny merged commit 468d80b into OpenAPITools:master Jul 24, 2020
@patst patst deleted the angular10 branch July 27, 2020 06:34
@wing328 wing328 mentioned this pull request Sep 4, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] [typescript-angular] Support Angular 10
4 participants