Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php-symfony] Update model_variables.mustache #7074

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

Starkmann
Copy link
Contributor

Recursive validate non primitive objects

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Recursive validate non primitive objects
@wing328
Copy link
Member

wing328 commented Aug 2, 2020

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)

@ybelenko
Copy link
Contributor

ybelenko commented Aug 2, 2020

Did you update samples? Weird, no changes in samples at all.

@ybelenko ybelenko changed the title Update model_variables.mustache [php-symfony] Update model_variables.mustache Apr 11, 2021
@wing328
Copy link
Member

wing328 commented Apr 13, 2021

Tested locally by making category a required property, I got the following (partial result):

     /**
-     * @var OpenAPI\Server\Model\Category|null
+     * @var OpenAPI\Server\Model\Category
      * @SerializedName("category")
+     * @Assert\NotNull()
+     * @Assert\Valid()
      * @Assert\Type("OpenAPI\Server\Model\Category")
      * @Type("OpenAPI\Server\Model\Category")
      */

@wing328 wing328 added this to the 5.1.1 milestone Apr 13, 2021
@wing328 wing328 merged commit 7a1f7b2 into OpenAPITools:master Apr 13, 2021
@wing328
Copy link
Member

wing328 commented May 25, 2022

#11810 has been merged to support Symfony 6. Please give it a try and let us know if you've any feedback or question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants