Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid warning about inline schemas in allOf #7319 #7446

Closed
wants to merge 1 commit into from
Closed

Remove invalid warning about inline schemas in allOf #7319 #7446

wants to merge 1 commit into from

Conversation

typhoon2k
Copy link
Contributor

To close #7319.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

if (modelImplCnt++ > 1) {
LOGGER.warn("More than one inline schema specified in allOf:. Only the first one is recognized. All others are ignored.");
break; // only one schema with discriminator allowed in allOf
once(LOGGER).error("Allof composed schema is inheriting >1 discriminator. Only use one discriminator: {}", composed);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
once(LOGGER).error("Allof composed schema is inheriting >1 discriminator. Only use one discriminator: {}", composed);
once(LOGGER).error("allOf composed schema is inheriting >1 discriminator. Only use one discriminator: {}", composed);

@wssrcok
Copy link

wssrcok commented May 19, 2021

I'm getting this warning, why don't we take all refs

@typhoon2k typhoon2k closed this Sep 28, 2021
@consultantleon
Copy link

why is this not merged yet?
(I'd update @marcelstoer 's comment first though regarding correct capitalisation of allOf in the log message).

But the check on modelImplCnt should definitely be removed, it breaks the check on multiple discriminators and the logged warning is invalid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid warning about inline schema usage in allOf
4 participants